feat: Add BrushIcon to Icon Collection#1502
feat: Add BrushIcon to Icon Collection#1502Rajesh-Nagarajan-11 merged 5 commits intolayer5io:masterfrom
Conversation
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new BrushIcon component and its corresponding index file. Review feedback indicates that the SVG path provided actually represents a pencil icon rather than a brush, and a correction has been suggested. Additionally, the icon should be exported from the main icons index file to ensure it is accessible throughout the application.
| xmlns="http://www.w3.org/2000/svg" | ||
| {...props} | ||
| > | ||
| <path d="M20.71 7.04c.39-.39.39-1.02 0-1.41l-2.34-2.34c-.39-.39-1.02-.39-1.41 0l-1.83 1.83 3.75 3.75 1.83-1.83zM3 17.25V21h3.75L17.81 9.94l-3.75-3.75L3 17.25z" /> |
There was a problem hiding this comment.
The SVG path provided corresponds to the 'Edit' (pencil) icon, which is already present in the icon collection. If the intention is to add a 'Brush' icon, please use the correct path from the Material Design set.
| <path d="M20.71 7.04c.39-.39.39-1.02 0-1.41l-2.34-2.34c-.39-.39-1.02-.39-1.41 0l-1.83 1.83 3.75 3.75 1.83-1.83zM3 17.25V21h3.75L17.81 9.94l-3.75-3.75L3 17.25z" /> | |
| <path d="M7 14c-1.1 0-2 .9-2 2 0 1.1.9 2 2 2s2-.9 2-2c0-1.1-.9-2-2-2zm3.71-3.12c-.39-.39-1.02-.39-1.41 0L3.27 16.9c-.39.39-.39 1.02 0 1.41.39.39 1.02.39 1.41 0l6.03-6.03c.38-.39.38-1.03 0-1.4zM21 3h-3c-.55 0-1 .45-1 1v3c0 .55.45 1 1 1h3c.55 0 1-.45 1-1V4c0-.55-.45-1-1-1zm-8 4h-3c-.55 0-1 .45-1 1v3c0 .55.45 1 1 1h3c.55 0 1-.45 1-1V8c0-.55-.45-1-1-1z" /> |
| @@ -0,0 +1 @@ | |||
| export { default as BrushIcon } from './BrushIcon'; | |||
There was a problem hiding this comment.
The BrushIcon is not exported from the main src/icons/index.ts file. Please add export * from './BrushIcon'; to the root index file to ensure the new icon is accessible to other components.
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
|
@rishiraj38 thank you for the suggested changes, I have committed the update |
|
Thank you, @icoderarely. Next time, please add screenshots reflecting the changes to the PR description. Doing so makes the review process much easier. Here is an example of how you can add screenshots. I tested the icon locally inside the Layer5 website, and this is how it looks: 
I added the icon with the following code inside layer5 index.js file.
|
|
LGTM, thank you @icoderarely |
|
@Katotodan I was not sure where to test earlier, but I tested the last one and it was a BrushIcon. Thank you for the tip. I usually use PoC videos or screenshots, which I missed it this time. |
5 participants
Notes for Reviewers
This PR fixes #1489
Signed commits